Skip to content

MINOR: Make feature lists immutable #20052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

MINOR: Make feature lists immutable #20052

merged 2 commits into from
Jun 30, 2025

Conversation

yunchipang
Copy link
Contributor

@yunchipang yunchipang commented Jun 26, 2025 •
edited by github-actions bot
Loading

Replaces .collect(Collectors.toList()) with .toList() for feature
collections, ensuring they are immutable and preventing accidental
modification.

Reviewers: TaiJuWu tjwu1217@gmail.com, Yung
yungyung7654321@gmail.com, Ken Huang s7133700@gmail.com, TengYao
Chi frankvicky@apache.org

@github-actions github-actions bot added triage PRs from the community core Kafka Broker small Small PRs labels Jun 26, 2025
Yunyung
Yunyung approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@Yunyung Yunyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

m1a2st
m1a2st approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@github-actions github-actions bot removed the triage PRs from the community label Jun 28, 2025
@yunchipang
Copy link
Contributor Author

flaky test ConsumerBounceTest#testConsumerReceivesFatalExceptionWhenGroupPassesMaxSize did not pass, re-running. jira: KAFKA-7964

frankvicky
frankvicky approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunchipang: LGTM

@frankvicky frankvicky merged commit 975fe75 into apache:trunk Jun 30, 2025
24 checks passed
jiafu1115 pushed a commit to jiafu1115/kafka that referenced this pull request Jul 2, 2025
@yunchipang
MINOR: Make feature lists immutable (apache#20052)
3012e77 
Replaces `.collect(Collectors.toList())` with `.toList()` for feature
collections, ensuring they are immutable and preventing accidental
modification.

Reviewers: TaiJuWu <tjwu1217@gmail.com>, Yung
<yungyung7654321@gmail.com>, Ken Huang <s7133700@gmail.com>, TengYao Chi
<frankvicky@apache.org>
jiafu1115 pushed a commit to jiafu1115/kafka that referenced this pull request Jul 3, 2025
@yunchipang
MINOR: Make feature lists immutable (apache#20052)
9c857e3 
Replaces `.collect(Collectors.toList())` with `.toList()` for feature
collections, ensuring they are immutable and preventing accidental
modification.

Reviewers: TaiJuWu <tjwu1217@gmail.com>, Yung
<yungyung7654321@gmail.com>, Ken Huang <s7133700@gmail.com>, TengYao Chi
<frankvicky@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaiJuWu TaiJuWu

@Yunyung Yunyung

@frankvicky frankvicky

@m1a2st m1a2st

Assignees
No one assigned
Labels
ci-approved core Kafka Broker small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yunchipang @TaiJuWu @Yunyung @frankvicky @m1a2st @chia7712