[SPARK-52535][SQL] Improve code readability of rule ApplyColumnarRulesAndInsertTransitions #51227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sAndInsertTransitions
zhztheplayer
commented
Jun 20, 2025
| @@ -537,6 +539,19 @@ case class ApplyColumnarRulesAndInsertTransitions( | |||
| false | |||
| } | |||
| plan.withNewChildren(plan.children.map(insertTransitions(_, outputsColumnar))) | |||
| } else { | |||
There was a problem hiding this comment.
The if-else clause
if (plan.isInstanceOf[ColumnarToRowTransition]) {
...
} else {
...
}is inverted here to ensure symmetry with the code in ensureOutputsColumnar.
|
Would someone like to review the PR? Thanks! |
|
thanks, merging to master! |
|
@cloud-fan @revans2 Thank you! |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 14, 2025
…sAndInsertTransitions Issue: https://issues.apache.org/jira/browse/SPARK-52535 ### What changes were proposed in this pull request? A minor cleanup on the code of `ApplyColumnarRulesAndInsertTransitions` to improve readability. ### Why are the changes needed? The rule is important for 3rd SQL plugins and the code got messed up a bit during the development iterations back then. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#51227 from zhztheplayer/wip-transition-rule-cleanup. Authored-by: Hongze Zhang <hongze.zzz123@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.apache.org/jira/browse/SPARK-52535
What changes were proposed in this pull request?
A minor cleanup on the code of
ApplyColumnarRulesAndInsertTransitionsto improve readability.Why are the changes needed?
The rule is important for 3rd SQL plugins and the code got messed up a bit during the development iterations back then.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.