`errorPolicy` is not defined on `FetchMoreQueryOptions` interface for `fetchMore`

[dlin303]

Issue Description

The fetchMore function doesn't take in an errorPolicy in its FetchMoreQueryOptions:

apollo-client/src/core/watchQueryOptions.ts

Lines 159 to 165 in cfb1ecd

	export interface FetchMoreQueryOptions<TVariables, TData = any> {
	/** {@inheritDoc @apollo/client!QueryOptionsDocumentation#query:member} */
	query?: DocumentNode | TypedDocumentNode<TData, TVariables>;
	/** {@inheritDoc @apollo/client!QueryOptionsDocumentation#variables:member} */
	variables?: Partial<TVariables>;
	context?: DefaultContext;
	}

However, under the hood, if errorPolicy for fetchMore is specified, fetchMore will perform a shallow merge of its options with the original query, with the specified FetchMoreQueryOptions taking precedence.

We should expose the errorPolicy type in FetchMoreQueryOptions to remove ambiguity surrounding its behavior when using TypeScript.

Other notes:

• If variables is included as an option for fetchMore, the shallow merge will succeed and fetchMore will inherit the errorPolicy from the original query.
• If query is included as an option for fetchMore, the original query options will be disregarded (all options will revert to their default values).

Discord discussion: https://discord.com/channels/1022972389463687228/1329263008542625804/1329263008542625804

Link to Reproduction

https://codesandbox.io/p/sandbox/repro-11612-forked-rmdvfd?file=%2Fsrc%2FApp.js

Reproduction Steps

Click 'Query' button to fire off original query. Click 'fetchMore' button to paginate with the 'fetchMore' call which respects the specified errorPolicy in its options. The current type definition of FetchMoreQueryOptions would have you think otherwise.

Note: that if you remove the 'errorPolicy' from fetchMore and specify the query option, the pagination call will fail as it no longer inherits the original errorPolicy: "all".

@apollo/client version

3.9.5

[jerelmiller]

Hey @dlin303 👋

Thanks for your patience on this issue! I've got good news! We now have an official implementation in our next major version of Apollo Client that will allow you to provide an errorPolicy to fetchMore. We are now by default executing fetchMore with an errorPolicy of none, but providing errorPolicy to fetchMore will use that value instead. If you're curious for more details, see #12714.

We just released this change in 4.0.0-alpha.23 and 4.0.0-rc.0. We'd love for you to try this out and provide any feedback before we publicly release 4.0. I hope you like the update!

Since this has been merged and released in a prerelease, I'm going to go ahead and close this issue. If you find any issues, please file a new issue and we'd love to take a look. Thanks!

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[dlin303]

Thats great news! Thank you!