Skip to content

pluggable incremental handlers #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Jun 18, 2025
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jun 13, 2025

builds on a rebased version of #12694 on top of #12698

Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 0cb0350

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 13, 2025

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12700

commit: 6487dd9

Copy link
Contributor

github-actions bot commented Jun 13, 2025

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 42.65 KB (+0.96% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.72 KB (+0.71% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.59 KB (+0.28% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 26.96 KB (-0.36% 🔽)
import { ApolloProvider } from "@apollo/client/react" 5.68 KB (+1.95% 🔺)
import { ApolloProvider } from "@apollo/client/react" (production) 963 B (0%)
import { useQuery } from "@apollo/client/react" 6.95 KB (+1.52% 🔺)
import { useQuery } from "@apollo/client/react" (production) 2.2 KB (+0.14% 🔺)
import { useLazyQuery } from "@apollo/client/react" 6.88 KB (+1.8% 🔺)
import { useLazyQuery } from "@apollo/client/react" (production) 2.14 KB (0%)
import { useMutation } from "@apollo/client/react" 6.23 KB (+1.96% 🔺)
import { useMutation } from "@apollo/client/react" (production) 1.48 KB (+0.2% 🔺)
import { useSubscription } from "@apollo/client/react" 6.55 KB (+1.78% 🔺)
import { useSubscription } from "@apollo/client/react" (production) 1.8 KB (+0.22% 🔺)
import { useSuspenseQuery } from "@apollo/client/react" 8.33 KB (+1.23% 🔺)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.61 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 8.09 KB (+1.46% 🔺)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.37 KB (-0.12% 🔽)
import { useLoadableQuery } from "@apollo/client/react" 8.07 KB (+1.32% 🔺)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.36 KB (0%)
import { useReadQuery } from "@apollo/client/react" 6.35 KB (+1.73% 🔺)
import { useReadQuery } from "@apollo/client/react" (production) 1.62 KB (-0.07% 🔽)
import { useFragment } from "@apollo/client/react" 6.4 KB (+1.59% 🔺)
import { useFragment } from "@apollo/client/react" (production) 1.68 KB (-0.12% 🔽)

@phryneas phryneas force-pushed the pr/httplink-accept branch from dd681d0 to d5d0fa5 Compare June 13, 2025 17:22
Base automatically changed from pr/httplink-accept to release-4.0 June 13, 2025 17:29
@jerelmiller jerelmiller changed the base branch from release-4.0 to pr/httplink-accept June 13, 2025 20:17
@jerelmiller jerelmiller changed the base branch from pr/httplink-accept to release-4.0 June 13, 2025 20:17
@phryneas phryneas force-pushed the pr/pluggable-defer-strategy branch from 0a0ab3e to b806f13 Compare June 18, 2025 08:12
@phryneas phryneas force-pushed the pr/pluggable-defer-strategy branch from b806f13 to 2e97b67 Compare June 18, 2025 08:22
@@ -75,8 +74,6 @@ export interface DefaultContext extends Record<string, any> {
clientAwareness?: ClientAwarenessLink.ClientAwarenessOptions;
}

export type QueryListener = (queryInfo: QueryInfo) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more minor suggestions, but generally approved. Sorry this ballooned on you, but thanks for getting this in! I feel much more confident about @defer moving forward as a result.

@phryneas phryneas merged commit 8e96e08 into release-4.0 Jun 18, 2025
31 of 32 checks passed
@jerelmiller jerelmiller deleted the pr/pluggable-defer-strategy branch June 19, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make defer implementation of HttpLink pluggable
2 participants