-
Notifications
You must be signed in to change notification settings - Fork 2.7k
pluggable incremental handlers #12700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0cb0350 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
size-limit report 📦
|
dd681d0
to
d5d0fa5
Compare
0a0ab3e
to
b806f13
Compare
b806f13
to
2e97b67
Compare
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
@@ -75,8 +74,6 @@ export interface DefaultContext extends Record<string, any> { | |||
clientAwareness?: ClientAwarenessLink.ClientAwarenessOptions; | |||
} | |||
|
|||
export type QueryListener = (queryInfo: QueryInfo) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more minor suggestions, but generally approved. Sorry this ballooned on you, but thanks for getting this in! I feel much more confident about @defer
moving forward as a result.
builds on a rebased version of #12694 on top of #12698