Skip to content

Set up a CODEOWNERS file for this repository #2208

Closed
@alexcrichton

Description

@alexcrichton

Unlike the Wasmtime repository this repository does not have automatic assignment of incoming PRs to a reviewer. By default I typically review PRs but for my own PRs I rely on others to be subscribed to this repository (which is not an assumption I'd like to have to make) or need to manually solicit a review (which I often forget about or can feel awkward doing sometimes). I'd like to instead move to a system similar to Wasmtime where a reviewer is automatically selected with the understanding that they can always pass it on as well. From a practical standpoint I'd still try to review any non-me-authored PRs, but ideally it'd help reduce the "me is the bus factor" and also help assign my own PRs to someone without requiring a subscription to the repository.

My thinking is to implement this change we'd add a new team to the BA, wasm-tools-default-reviewers, and specify that in CODEOWNERS under the * path. We could add more refined teams over time if some folks are interested in just one tool over others, but for now I'm thinking we'd have a single team.

For initial membership of this review rotation I'd imagine pulling in a subset of me, @fitzgen, @dicej, @pchickey, and @abrown. What do y'all think of this? Would you prefer to not be in such a rotation? Or do y'all know of others who'd be a good fit?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions