-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[CHORE]: enforce default limit on get when none is supplied #4942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Enforce Default and Maximum Limits for get, list_collections, and list_databases (Service-Based Frontend) This PR enforces a default maximum limit (1000) for collection and database listing and 'get' operations in the Rust service-based frontend when the client does not specify a limit. It also ensures that client-supplied limits exceeding this maximum result in a validation error, making API behavior more predictable and resilient. Test utilities and invariants are updated in Python to support and test this behavior. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
…per/use-match-for-default-quotas
…com/chroma-core/chroma into cooper/default-limit-get
…com/chroma-core/chroma into cooper/default-limit-get
…com/chroma-core/chroma into cooper/default-limit-get
…per/use-match-for-default-quotas
…com/chroma-core/chroma into cooper/default-limit-get
Description of changes
Enforces a default limit of 1000 on
get
,list_collections
, andlist_databases
when none is provided, only on the service-based frontend.Test plan
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A