Skip to content

cli/doctor: handle truncated rows gracefully in zipdir #148840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Jun 25, 2025

When debug doctor is run on zipdir files which are corrupt / incomplete
it can end up crashing. This patch aims to generate a more productive
error message if any row does not have enough fields in any file format.
Currently this always hits an index out of range error.

Fixes: #147722

Release note: None

When debug doctor is run on zipdir files which are corrupt / incomplete
it can end up crashing. This patch aims to generate a more productive
error message if any row does not have enough fields in any file format.
Currently this always hits an index out of range error.

Fixes: cockroachdb#147722

Release note: None
@fqazi fqazi requested a review from a team as a code owner June 25, 2025 18:14
@fqazi fqazi added the backport-all Flags PRs that need to be backported to all supported release branches label Jun 25, 2025
@fqazi fqazi requested a review from a team as a code owner June 25, 2025 18:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi
Copy link
Collaborator Author

fqazi commented Jun 30, 2025

@rafiss TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all Flags PRs that need to be backported to all supported release branches target-release-25.4.0
Projects
None yet
3 participants