Skip to content

Update gRPC shared code #62340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Update gRPC shared code #62340

merged 2 commits into from
Jun 16, 2025

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 13, 2025

gRPC JSON transcoding has some shared code with Grpc.AspNetCore.Server. It is just a copy of the source code that is shared between the two repos.

I've updated the shared code in this PR.

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Jun 13, 2025
@JamesNK JamesNK force-pushed the jamesnk/grpc-shared-code-update branch from 7f72d21 to 3e88746 Compare June 13, 2025 03:24
@JamesNK JamesNK requested a review from BrennanConroy June 13, 2025 03:28
@mitchdenny
Copy link
Member

Any way for that to be less manual to sync the shared code?

@JamesNK
Copy link
Member Author

JamesNK commented Jun 16, 2025

I don't think it's worth investigating in improving. This is the first time I've synced them in 4 years.

@JamesNK JamesNK merged commit 5cb623c into main Jun 16, 2025
27 checks passed
@JamesNK JamesNK deleted the jamesnk/grpc-shared-code-update branch June 16, 2025 06:26
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview6 milestone Jun 16, 2025
@mitchdenny
Copy link
Member

I don't think it's worth investigating in improving. This is the first time I've synced them in 4 years.

OK then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants