Add missing XML documentation for android.hardware.camera

[IeuanWalker]

#2885

[adegeo]

I like the idea of ordering them in the same way, but the XML comment isn't easily visible when reading the article. Restoring the XML comment above the setting helps readability. Maybe even adding a blank line in there between items.

Perhaps match the ordering in the block at the top of the article?

I also noticed that the linked issue doesn't seem to match what you're changing? In that you talk about the camera?

[IeuanWalker]

@adegeo no prob, will take a look tomorrow.

The linked issue is about these 2 lines being missing, which have been added -

[IeuanWalker]

I like the idea of ordering them in the same way, but the XML comment isn't easily visible when reading the article. Restoring the XML comment above the setting helps readability. Maybe even adding a blank line in there between items.

The block at the top of the article also be set to match.

I also noticed that the linked issue doesn't seem to match what you're changing? In that you talk about the camera?

@adegeo I've moved the comments back above each option.

---

I haven't added "a blank line in there between items", because currently the blank lines indicate the permission for the different features -

Not sure what you meant by "The block at the top of the article also be set to match"

[adegeo]

Wow, I don't know how I ended up wording that sentence in that way. I think I spliced two sentences together while editing and didn't realize how awful it sounded. HA!

I edited my comment to fix the grammar. I was referencing the ordering in the article above where the change was made, that ordering could match the ordering in the xml:

EDIT:
After looking a bit more at this, and the published versions (original vs updated) I don't think I like this change because it makes it unclear what's required specifically for the picker. Sure, in your actual app you may want to structure the XML better than this sample, but this sample is really tuned to show that:

• READ and WRITE are required for Android 12
• The individual items are required for Android 13.

Having them all listed as the original version did, makes that clear.

[IeuanWalker]

But in that case shouldnt both assembly and manifest versions be laid out in the same way.

Personally i think the assembly is more clearly laid out compared to the manifest version, especially if your only using part of the feature and don't need all the permissions etc.

So this PR just updates the manifest to match the assembly version, and adds the missing XML, i.e. -

  <!-- Add these properties if you would like to filter out devices that do not have cameras, or set to false to make them optional -->
  <uses-feature android:name="android.hardware.camera" android:required="true"/>
  <uses-feature android:name="android.hardware.camera.autofocus" android:required="true"/>