-
Notifications
You must be signed in to change notification settings - Fork 1.1k
OTel experimentation #49409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
baronfel
wants to merge
17
commits into
dotnet:main
Choose a base branch
from
baronfel:otel-maybe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
OTel experimentation #49409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
…nts and several nullable disable removals. Changed s_source to Source as a static property.
…ader and ToolPackageDownloaderBase since those will be updated in main. Not interested in cleaning up test files.
Otel PR cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely exploratory so far - we can't use AppInsights libraries if we do AOT in the SDK, so I'm exploring what an OTel-based way of doing telemetry might look like.
Q: telemetry filtering/hashing
A: for now we should keep everything as it is. As we make new activities, we should use
Activity.IsAllDataRequested
as a check before adding/computing expensive data.Q: do we keep the store-out-of-band-then-rehydrate-and-send approach, or just do a best-case flush?
A: We can be very optimistic! We can have multiple collectors, each for different purposes. The default OTel collector can be for local use only (by default) and can be verbose, while the Azure Monitor collector can be for production only and be more restrained. Each Collector has its own implementation, and the Azure Monitor collector even handles durable message persistence, so we can delete all of our current implementation. We should still have it store its durable store to our owned directory, though.
Example Aspire Dashboard outputs for

dotnet new classlib
:Telemetry events are visible in this view if the CLI is opted in to telemetry.