Kotlin: Set up ktfmt in OSS #52064
Closed
Kotlin: Set up ktfmt in OSS #52064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cortinico
reviewed
Jun 17, 2025
Closed
facebook-github-bot
added
the
Shared with Meta
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
Summary: Following up from #52064 (comment), this PR removes lint-java and its related files. The codebase is moving entirely to Kotlin and a Kotlin linter is being setup as well, the usage of the Java linter will become unnecessary. ## Changelog: [INTERNAL] - Remove lint-java Pull Request resolved: #52092 Test Plan: Relying on CI here to be green. Reviewed By: cortinico Differential Revision: D76880712 Pulled By: sbuggay fbshipit-source-id: 2736772e7347f435b17d007e0322e1afc2fb2d7b
cortinico
reviewed
Jul 2, 2025
cortinico
approved these changes
Jul 11, 2025
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D78272876. |
|
@cortinico merged this pull request in 42b8921. |
|
This pull request was successfully merged by @mateoguzmana in 42b8921 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds the basic
ktfmtsetup in OSS to lint Kotlin files before they're imported into the Meta codebase, making collaboration with external contributors smoother for Android related PRs.I tried to put together certain rules that mimic the current code style and it seems to work well as I get no errors for properly formatted files but this still might need some input to have the correct configuration.
Added two scripts to the main package.json:
yarn lint-kotlin-checkyarn lint-kotlinChangelog:
[INTERNAL] - Kotlin: Set up ktfmt in OSS
Test Plan:
Unformat any random Kotlin file inside ReactAndroid and then run: