Add edge-to-edge opt-in support #52088
Open
+193
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@sbuggay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
alanleedev
reviewed
Jun 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/EdgeToEdge.kt
Outdated
Show resolved
Hide resolved
cortinico
reviewed
Jun 18, 2025
...e-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/ProjectUtils.kt
Show resolved
Hide resolved
...-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PropertyUtils.kt
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/EdgeToEdgeFlags.kt
Outdated
Show resolved
Hide resolved
|
@sbuggay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This follows #47554
Compared to the initial proposal, I had to remove the
edgeToEdgeEnabledproperty from the rootgradle.propertiesand put it in the appgradle.propertiesinstead (explaining theAgpConfiguratorUtils.kt/GenerateEntryPointTask.kt/ProjectUtils.kt/PropertyUtils.ktchanges)This PR:
MainActivity(whenedgeToEdgeEnabledis set totrue)StatusBarbackgroundColorandtranslucent(whenedgeToEdgeEnabledis set totrue)statusBarTranslucentandnavigationBarTranslucentonModalwhen edge-to-edge is enabledisEdgeToEdgeconstant toDeviceInfoModuleforreact-native-is-edge-to-edgedetectionChangelog:
Test Plan:
enableEdgeToEdgevalue inpackages/rn-tester/android/app/gradle.propertiesdemo.mp4