Skip to content

C++: Retrieve namespace attributes #19773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025
Merged

C++: Retrieve namespace attributes #19773

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b112b93
C++: add `namespaceattributes` table to store namespace attributes
IdrissRio Jun 16, 2025
e6f1183
C++: add predicate to `Namespace` class to retrieve associated attrib…
IdrissRio Jun 16, 2025
927c220
C++: add change note for `Namespace`
IdrissRio Jun 16, 2025
fc9e5bd
C++: add upgrade and downgrade scripts
IdrissRio Jun 16, 2025
09bc57a
C++: update stats file
IdrissRio Jun 16, 2025
9fb47cc
C++: add tests for attribute extraction on namespace
IdrissRio Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,499 changes: 2,499 additions & 0 deletions cpp/downgrades/9baef67d1ffc1551429dbe1c1130815693e28218/old.dbscheme
View file
Open in desktop

Large diffs are not rendered by default.

2,494 changes: 2,494 additions & 0 deletions cpp/downgrades/9baef67d1ffc1551429dbe1c1130815693e28218/semmlecode.cpp.dbscheme
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions cpp/downgrades/9baef67d1ffc1551429dbe1c1130815693e28218/upgrade.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
description: Add a predicate `getAnAttribute` to `Namespace`
compatibility: full
namespaceattributes.rel: delete
4 changes: 4 additions & 0 deletions cpp/ql/lib/change-notes/2025-06-16-namespace-attributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: feature
---
* Added a predicate `getAnAttribute` to `Namespace` to retrieve a namespace attribute.
5 changes: 5 additions & 0 deletions cpp/ql/lib/semmle/code/cpp/Namespace.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ class Namespace extends NameQualifyingElement, @namespace {

/** Gets a file which declares (part of) this namespace. */
File getAFile() { result = this.getADeclarationEntry().getLocation().getFile() }

/** Gets an attribute of this namespace. */
Attribute getAnAttribute() {
namespaceattributes(underlyingElement(this), unresolveElement(result))
Copy link
Preview

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The predicate call isn’t assigned to the result variable, so the method won’t return any values. It should read:

result = namespaceattributes(underlyingElement(this), unresolveElement(result));
Suggested change
namespaceattributes(underlyingElement(this), unresolveElement(result))
result = namespaceattributes(underlyingElement(this), unresolveElement(result))

Copilot uses AI. Check for mistakes.

}
}

/**
Expand Down
5 changes: 5 additions & 0 deletions cpp/ql/lib/semmlecode.cpp.dbscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,6 +1139,11 @@ varattributes(
int spec_id: @attribute ref
);

namespaceattributes(
int namespace_id: @namespace ref,
int spec_id: @attribute ref
);

stmtattributes(
int stmt_id: @stmt ref,
int spec_id: @attribute ref
Expand Down
Loading