You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the gh gei migrate-secret-alerts to migrate alerts, the resolution comments from the source alert are also mapped over to the target alerts. Which works fine but can be further improved to include the original resolver name into the comment. The reason for this is because typicall the gh gei migrate-secret-alerts in migrations is run with tokens generated by GitHub Apps therefore the resolver in the target alert is a tool therefore we are losing the useful information of who originally closed an alert.
Example
Source alert resolution comment:
After migrating it with a workflow that uses GitHub App to generate tokens, the target alert does not show @theztefan as closer by rather ghas-control[bot].
Proposed improvement
This result expected and not a bug! The suggestion is to also transfer the resolver name as part of the comment in the target alert. So the result in the example above would be ghas-control[bot] closed this with a comment @theztefan: Revoked today.
The text was updated successfully, but these errors were encountered:
Description
When using the
gh gei migrate-secret-alerts
to migrate alerts, the resolution comments from the source alert are also mapped over to the target alerts. Which works fine but can be further improved to include the original resolver name into the comment. The reason for this is because typicall thegh gei migrate-secret-alerts
in migrations is run with tokens generated by GitHub Apps therefore the resolver in the target alert is a tool therefore we are losing the useful information of who originally closed an alert.Example
Source alert resolution comment:
After migrating it with a workflow that uses GitHub App to generate tokens, the target alert does not show
@theztefan
as closer by ratherghas-control[bot]
.Proposed improvement
This result expected and not a bug! The suggestion is to also transfer the resolver name as part of the comment in the target alert. So the result in the example above would be
ghas-control[bot] closed this
with a comment@theztefan: Revoked today
.The text was updated successfully, but these errors were encountered: