-
Notifications
You must be signed in to change notification settings - Fork 108
Fixes secret scanning alerts migration - locations processing and matching #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes secret scanning alerts migration - locations processing and matching #1330
Conversation
Unit Test Results 1 files 1 suites 20s ⏱️ Results for commit 52f79bb. ♻️ This comment has been updated with latest results. |
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only thing is test.output
should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
INT tests are all 🟢 merging now. |
This PR addresses a bug reported #1331 where Secret Scanning alerts with non-commit locations (e.g., pull_request_comment, issue_title, issue_body) were:
NullReferenceException
exceptions was throwncommit
andwiki_commit
locations was not correct. The issue was the strict URL comparison logic, which failed when the base URL differed between source and target repository.Changes Made:
BuildSecretScanningAlertLocation
method to make it more robust by safely accessing properties when building the object insrc/Octoshift/Services/GithubApi.cs
AreLocationsEqual
function insrc/Octoshift/Services/SecretScanningAlertService.cs
:commit
andwiki_commit
locations, the comparison remains strict, checking all relevant fieldsDocs updated (or issue created)New package licenses are added toThirdPartyNotices.txt
(if applicable)