Update CreateTeamCommandBase.cs #1335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a description to make it clearer that this option only works with Enterprise Managed Users.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CreateTeamCommandBase.cs file to add a clear description for the IdpGroup option, clarifying that it applies only to Enterprise Managed Users as noted in migration friction 3294.
- Added a detailed description for the IdpGroup option.
- Clarified usage constraints in the command description.
Unit Test Results 1 files 1 suites 21s ⏱️ Results for commit 1b3398c. ♻️ This comment has been updated with latest results. |
ArinGhazarian
suggested changes
May 1, 2025
| @@ -17,7 +17,9 @@ public CreateTeamCommandBase() : base(name: "create-team", description: "Creates | |||
| public virtual Option<string> TeamName { get; } = new("--team-name") { IsRequired = true }; | |||
|
|
|||
| public virtual Option<string> IdpGroup { get; } = new("--idp-group"); | |||
|
|
|||
| { | |||
| Description = "The Identity Provider Group to link the team to. For Enterprise Managed Users only." | |||
There was a problem hiding this comment.
there is an extra semi colon on line 19 that is a syntax error, once deleted the build should succeed.
As per review
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a description to make it clearer that this option only works with Enterprise Managed Users. This is as per migration friction 3294.
ThirdPartyNotices.txt(if applicable)