Unable to add teams to a repo

[nbmha1]

Problem Description

Safe Settings is able to remove teams from a repo based on configuration, but not able to add teams to a repo.

What is actually happening

^^

What is the expected behavior

The GitHub teams should be added to the repo.

Error output, if available

No errors. There is a comment in the code refering to the GitHub API. Has the endpoint changed for github.com and this is not reflected in code?

Context

We are trying to run safe-settings with suborg's settings files.

Are you using the hosted instance of probot/settings or running your own?

We are running probot in our own container.

If running your own instance, are you using it with github.com or GitHub Enterprise?

Github.com

Version of probot/settings

Latest.

Version of GitHub Enterprise

NA

[svg153]

We are using safe-settings with teams and members, and we do not have any problems. But our teams do not have any space in their name.

Its usage is a bit confusing. You have to put the name of the team instead of the team_slug or the id. Example:

If you have a team: https://github.com/orgs/ORG/teams/dev and its name is "Devs", in safe-settings you have to put "Devs" instead of the team_slug, "dev" or "@org/dev".

That is, you would have to put these names:

ORG=myOrganization
gh api \
   -H "Accept: application/vnd.github.v3+json" \
   /orgs/${ORG}/teams --jq ".[].name"

[decyjphr]

@svg153 thanks for helping out.