Help with Setup with docker and Other bugs

[bheemvennapureddy]

Few Questions :

1. if we are using Github Enterprise Cloud or is this only Self hosted github ?
2. From Setup point of view if we run the app ( say on a Ec2 ) we don't run or setup the the docker version of the app if i am correct.
3. Is there a easier way to test this ?

[bheemvennapureddy]

Seeing discrepancies with docker run not sure what i am missing - the app couldn't listen to the events from localhost where npm run dev works as usual here is the docker compose

logs

npm run dev fails here and there but atleast runs

[bheemvennapureddy]

What am i missing here if the probot app fails to post somethin check-run doesn't fail keeps running for ever

Failure from probot

[bheemvennapureddy]

Few more logs

[bheemvennapureddy]

@decyjphr can you give me some insights on this any help on this will be really appreciated. Thanks in advance

[decyjphr]

@bheemvennapureddy I'll get a patch release which should address your issue. I'll update this issue in a few hours when that is available.

[decyjphr]

@bheemvennapureddy can you try your testing with 2.1.1-rc.1 image and let me know?

[bheemvennapureddy]

@decyjphr will test in couple hours

[bheemvennapureddy]

@decyjphr which issues does this fix ?

[bheemvennapureddy]

@decyjphr never ending check is gone now but seeing a diff error on applying branch protection rules

"text": "Run on: `2023-11-02T06:26:52.683Z`\n\n#### Breakdown of Errors\n| Owner| Repo | Plugin | Error \n| --- | --- | --- | --- \nCuroFinTechCorp | safe-test | Branches | Error applying branch protection {"name":"HttpError","status":422,"response":{"url":"https://api.github.com/repos/CuroFinTechCorp/safe-test/branches/master/protection","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","connection":"close","content-length":"299","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 02 Nov 2023 06:26:52 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"administration=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; param=hellcat-preview.luke-cage-preview.zzzax-preview; format=json","x-github-request-id":"5EAF:33C2:BED49A2:1879FB54:6543412C","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14945","x-ratelimit-reset":"1698909920","x-ratelimit-resource":"core","x-ratelimit-used":"55","x-xss-protection":"0"},"data":{"message":"Invalid request.\\n\\nNo subschema in \\"anyOf\\" matched.\\nNo subschema in \\"oneOf\\" matched.\\nNot all subschemas of \\"allOf\\" matched.\\nFor 'anyOf/1', {\\"contexts\\"=>[]} is not a null.","documentation_url":"https://docs.github.com/rest/branches/branch-protection#update-branch-protection"}},"request":{"method":"PUT","url":"https://api.github.com/repos/CuroFinTechCorp/safe-test/branches/master/protection","headers":{"accept":"application/vnd.github.hellcat-preview+json,application/vnd.github.luke-cage-preview+json,application/vnd.github.zzzax-preview+json","user-agent":"probot/12.3.1 octokit-core.js/3.5.1 Node.js/21","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{\\"required_pull_request_reviews\\":{\\"required_approving_review_count\\":2,\\"dismiss_stale_reviews\\":true,\\"require_code_owner_reviews\\":false,\\"require_last_push_approval\\":true,\\"bypass_pull_request_allowances\\":{\\"apps\\":[],\\"users\\":[],\\"teams\\":[]},\\"dismissal_restrictions\\":{\\"users\\":[],\\"teams\\":[]}},\\"required_status_checks\\":{\\"contexts\\":[]},\\"enforce_admins\\":true,\\"restrictions\\":{\\"apps\\":[],\\"users\\":[],\\"teams\\":[]}}","request":{"retryCount":1}}}\n\n\n"

Settings.yml below

# These settings are synced to GitHub by https://github.com/github/safe-settings

repository:
  # Settings for Code security and analysis
  # Dependabot Alerts
  security:
    enableVulnerabilityAlerts: true
    enableAutomatedSecurityFixes: true
  
  # Either `true` to make the repository private, or `false` to make it public. 
  # If this value is changed and if Org members cannot change the visibility of repos
  # it would result in an error when updating a repo
  private: true
  
  # Can be public or private. If your organization is associated with an enterprise account using 
  # GitHub Enterprise Cloud or GitHub Enterprise Server 2.20+, visibility can also be internal. 
  visibility: private
  
  # Either `true` to enable issues for this repository, `false` to disable them.
  has_issues: true
  
  # Either `true` to enable projects for this repository, or `false` to disable them.
  # If projects are disabled for the organization, passing `true` will cause an API error.
  has_projects: true
  
  # Either `true` to enable the wiki for this repository, `false` to disable it.
  has_wiki: true
  
  # The default branch for this repository.
  default_branch: master
  
  # Desired language or platform [.gitignore template](https://github.com/github/gitignore) 
  # to apply. Use the name of the template without the extension. 
  # For example, "Haskell".
  gitignore_template: node
  
  # Choose an [open source license template](https://choosealicense.com/) 
  # that best suits your needs, and then use the 
  # [license keyword](https://help.github.com/articles/licensing-a-repository/#searching-github-by-license-type) 
  # as the `license_template` string. For example, "mit" or "mpl-2.0".
  license_template: mit
  
  # Either `true` to allow squash-merging pull requests, or `false` to prevent
  # squash-merging.
  allow_squash_merge: true
  
  # Either `true` to allow merging pull requests with a merge commit, or `false`
  # to prevent merging pull requests with merge commits.
  allow_merge_commit: true
  
  # Either `true` to allow rebase-merging pull requests, or `false` to prevent
  # rebase-merging.
  allow_rebase_merge: true
  
  # Either `true` to allow auto-merge on pull requests, 
  # or `false` to disallow auto-merge.
  # Default: `false`
  allow_auto_merge: true
  
  # Either `true` to allow automatically deleting head branches 
  # when pull requests are merged, or `false` to prevent automatic deletion.
  # Default: `false`
  delete_branch_on_merge: true  
      
  # Whether to archive this repository. false will unarchive a previously archived repository.
  archived: false

# The following attributes are applied to any repo within the org
# So if a repo is not listed above is created or edited
# The app will apply the following settings to it
labels:
  # Labels: define labels for Issues and Pull Requests
  include:
    - name: bug
      color: CC0000
      description: An issue with the system

    - name: feature
      # If including a `#`, make sure to wrap it with quotes!
      color: '#336699'
      description: New functionality.

    - name: first-timers-only
      # include the old name to rename an existing label
      oldname: Help Wanted
      color: '#326699'

    - name: new-label
      # include the old name to rename an existing label
      oldname: Help Wanted
      color: '#326699'
  exclude:
    # don't delete any labels created on GitHub that starts with "release"
    - name: ^release
    
branches:
  # If the name of the branch value is specified as `default`, then the app will create a branch protection rule to apply against the default branch in the repo
  - name: default
    # https://docs.github.com/en/rest/reference/branches#update-branch-protection
    # Branch Protection settings. Set to null to disable
    protection:
      # Required. Require at least one approving review on a pull request, before merging. Set to null to disable.
      required_pull_request_reviews:
        # The number of approvals required. (1-6)
        required_approving_review_count: 2
        # Dismiss approved reviews automatically when a new commit is pushed.
        dismiss_stale_reviews: true
        # Blocks merge until code owners have reviewed.
        require_code_owner_reviews: false
        # Whether the most recent reviewable push must be approved by someone other than the person who pushed it.
        require_last_push_approval: true
        # Allow specific users, teams, or apps to bypass pull request requirements. Set to null to disable.
        bypass_pull_request_allowances:
          apps: []
          users: []
          teams: []
        # Specify which users and teams can dismiss pull request reviews. Pass an empty dismissal_restrictions object to disable. User and team dismissal_restrictions are only available for organization-owned repositories. Omit this parameter for personal repositories.
        dismissal_restrictions:
          users: []
          teams: []
      # Required. Require status checks to pass before merging. Set to null to disable
      required_status_checks:
        # Required. The list of status checks to require in order to merge into this branch
       contexts: []
      # Required. Enforce all configured restrictions for administrators. Set to true to enforce required status checks for repository administrators. Set to null to disable.
      enforce_admins: true
      # Required. Restrict who can push to this branch. Team and user restrictions are only available for organization-owned repositories. Set to null to disable.
      restrictions:
        apps: []
        users: []
        teams: []

[bheemvennapureddy]

@decyjphr My context object was wrong i got that fixed , but ideally i should have got notified when i updated that to wrong on the pull request validator but which went fine.

Post update to context protection applied successfully but how can we skip Require branches to be up to date before merging

[decyjphr]

I believe you can set

required_status_checks:
  strict: false
  contexts:[]

to disable require branches to be up to date before merging

[bheemvennapureddy]

@decyjphr how about on PR it doesn't explain which all repo's will have impact with context change