add support for repository variables (#798) #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decyjphr
requested changes
May 14, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds first-class support for repository-level variables, including plugin registration, implementation, and associated tests.
- Introduces a new
Variablesplugin for listing, creating, updating, and deleting repo variables - Registers the plugin in
lib/settings.js - Adds unit tests and fixtures for the variables functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/unit/lib/plugins/variables.test.js | New tests for the Variables plugin’s sync logic |
| test/fixtures/variables-config.yml | Fixture for variables configuration |
| lib/settings.js | Registers variables plugin alongside others |
| lib/plugins/variables.js | Implements the Variables class and its methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for repository-level variables that can be used outside of a specific deployment environment.
Fixed find function and unit test from this PR and resubmitted for approval. All credit to @primetheus!
cc: @decyjphr, @primetheus