Skip to content

Testing list blocks with the gRPC Provider #37236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

Testing list blocks with the gRPC Provider #37236

merged 4 commits into from
Jun 18, 2025

Conversation

dsa0x
Copy link
Member

@dsa0x dsa0x commented Jun 13, 2025

Fixes #

Target Release

1.13.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x force-pushed the sams/grpc-list-testing branch from 572aac4 to c5b213a Compare June 13, 2025 15:10
@dsa0x dsa0x marked this pull request as ready for review June 13, 2025 15:22
@dsa0x dsa0x requested a review from a team as a code owner June 13, 2025 15:22
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really unsure about the introduction of grpcwrap in the internal/terraform package. It feels like grcpwrap is only used for e2e tests and the simple providers so far. Maybe we can Zoom about this tomorrow?

if p.GetProviderSchemaResponse != nil {

for typeName, schema := range p.GetProviderSchemaResponse.ResourceTypes {
if schema.Identity != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the resource identity schemas come from the GetResourceIdentitySchemas call and not the other way around. I feel like extracting it from the ResourceTypes could lead to wrong assumptions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provider is a little different, in that it conforms to the internal providers.Provider interface rather than the protobuf interface. That means the schemas are already going to be coalesced into a single object. That's not to say that this may still be missing some edge case, just saying that it's not necessarily wrong to assume they are one and the same at this point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is only a fallback when you do not provide a separate resource identity response.

A followup e2e test would wire up both layers
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dsa0x dsa0x merged commit 3d3439e into main Jun 18, 2025
8 checks passed
@dsa0x dsa0x deleted the sams/grpc-list-testing branch June 18, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants