[IPL-7725] Updating Calls to the Remote HCP Terraform API to Retrieve All Workspace Variables #37241
+83
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Jun 16, 2025
| @@ -0,0 +1,5 @@ | |||
| kind: BUG FIXES | |||
| body: Retrieve all workspace variables while doing a `terraform import`, include variables inhertied from variable sets but not overwritten by the worskapce. | |||
There was a problem hiding this comment.
Suggested change
| body: Retrieve all workspace variables while doing a `terraform import`, include variables inhertied from variable sets but not overwritten by the worskapce. | |
| body: Retrieve all workspace variables while doing a `terraform import`, include variables inherited from variable sets but not overwritten by the workspace. |
go get github.com/hashicorp/jsonapi@v1.5.0
… all variables accessible to a workspace. This should include: - variables declared in the workspace and not overwritten by organization / project varset variables - variables inherited from organization / project varsets and not overwritten by workspace variables Other changes: Adding mocks for new functions in go-tfe after version upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original Problem
While doing a
terraform import, it was observed that variables inherited from variable sets in HCP Terraform were notgetting resolved, which caused the No value for required variable error. Usually, in such cases, terraform would make
an API call to HCP Terraform (via go-tfe client) to retrieve the list of variables accessible to the workspace. However,
the HCP Terraform API failed to include inherited variables that were not overwritten by workspace variables, which led
to the error.
Proposed Solution
We updated the HCP Terraform API to include the following variables for a workspace:
The updated API was included in the latest version (v1.83.0) of the go-tfe client, and this PR updates the go-tfe client
version and updates the API calls in the
terraform importcommand to use the new API.Note - the terraform
importblock does not face this issue since it is executed during a plan / apply run, andimporting variables from variable sets works as expected.
Testing
terraform importon a workspace with inherited variables from variablesets. Evidence attached below.
Documentation and External References
Target Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
NO
CHANGELOG entry
Testing Evidence