Update data stored in plan files to enable using PSS with saved plans #37246
+581
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich is used when handling plan files
SarahFrench
added
the
no-changelog-needed
3 tasks
… plan file. Add some test coverage.
… PSS, if present
SarahFrench
force-pushed
the
pss/store-pss-in-planfile
branch
from
7b80adb to
a2acc33
Compare
SarahFrench
commented
Jun 18, 2025
Comment on lines
+189
to
+196
| // TODO: Is this needed? Are there issues if the same provider is used for PSS and resource management also? | ||
| if p.StateStore.Provider != nil { | ||
| m[p.StateStore.Provider.Source.String()] = addrs.AbsProviderConfig{ | ||
| Module: addrs.RootModule, // state_store block is only in Root | ||
| Provider: *p.StateStore.Provider.Source, | ||
| // No aliases used for PSS provider. | ||
| } | ||
| } |
There was a problem hiding this comment.
This might benefit from some discussion/pair programming?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some prototyping/implementation for the PSS project that's only relevant to the apply command.
These changes enable saving PSS config in a plan, similar to how a planfile can store backend config and be used to configure a
backend.Backendduring an apply command that is supplied with a pre-existing plan file.Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry