Skip to content

chore: rename SUPPORTED to EOL_UPCOMING #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rlmestre
Copy link
Contributor

Partial change for https://github.com/neverendingsupport/data-and-integrations/issues/95. Does not close it yet because we need to make the same change in the report card too.

@rlmestre rlmestre requested a review from a team as a code owner June 18, 2025 14:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Renames the legacy SUPPORTED status to EOL_UPCOMING across UI, command logic, type definitions, and documentation.

  • Replace SUPPORTED keys with EOL_UPCOMING in status color mappings and indicators.
  • Update scan command output and count logic to use EOL_UPCOMING instead of SUPPORTED.
  • Adjust valid statuses in API types and clean up README usage flags.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/ui/shared.ui.ts Renamed SUPPORTED to EOL_UPCOMING in STATUS_COLORS and INDICATORS.
src/commands/scan/eol.ts Replaced SUPPORTED references with EOL_UPCOMING in destructuring, conditionals, logging, and grouping.
src/api/types/nes.types.ts Updated VALID_STATUSES constant to include EOL_UPCOMING.
README.md Removed references to the --all flag (formerly showing SUPPORTED) and updated usage examples.
Comments suppressed due to low confidence (2)

README.md:148

  • The USAGE line includes --json and -s but the FLAGS section no longer documents those options. Please add descriptions for --json and -s or remove them from the usage line to keep the documentation in sync.
  $ hd scan eol [--json] [-f <value>] [-p <value>] [-d <value>] [-s]

src/commands/scan/eol.ts:175

  • Add or update tests to verify that EOL_UPCOMING is correctly counted in countComponentsByStatus and displayed in displayResults.
    EOL_UPCOMING: 0,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant