fix: Enhance incident query to include alert enrichment for status #5062
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…chment extraction
…reflected-in-the-incident-view
dosubot
bot
added
the
size:S
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…uction for alert searches based on timeframe
…n-the-incident-view' of https://github.com/keephq/keep into 5049-Status-changes-for-an-incident-are-not-reflected-in-the-incident-view
dosubot
bot
added
size:M
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…n-the-incident-view' of https://github.com/keephq/keep into 5049-Status-changes-for-an-incident-are-not-reflected-in-the-incident-view
…reflected-in-the-incident-view Signed-off-by: Ihor Panasiuk <igorskynet13@gmail.com>
Signed-off-by: Ihor Panasiuk <igorskynet13@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ts_by_cel function
…n-the-incident-view' of https://github.com/keephq/keep into 5049-Status-changes-for-an-incident-are-not-reflected-in-the-incident-view
There was a problem hiding this comment.
Bug: Invalid Join Condition Causes Enrichment Failure
The outerjoin with incident_enrichment (an alias for AlertEnrichment) is flawed: its join condition cast(col(Incident.id), String) == foreign(incident_enrichment.alert_fingerprint) incorrectly attempts to match Incident.id (a UUID) with alert_fingerprint (an alert hash), which are unrelated identifiers, preventing incident enrichment data retrieval. The foreign() function is also misused here, as it's intended for SQLAlchemy relationship definitions. Additionally, this incident_enrichment join is unconditionally added to all queries built by __build_base_incident_query, causing unnecessary performance overhead for queries that do not require enrichment data.
keep/api/core/incidents.py#L256-L264
keep/keep/api/core/incidents.py
Lines 256 to 264 in 2406a60
Was this report helpful? Give feedback by reacting with 👍 or 👎
skynetigor
deleted the
5049-Status-changes-for-an-incident-are-not-reflected-in-the-incident-view
branch
Closes #5049
📑 Description
✅ Checks
ℹ Additional Information