Skip to content

[12.x] Optimise join and set functions in Arr class #56042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JordanchoEftimov
Copy link
Contributor

Improve Arr::set and Arr::join for clarity and performance

  • Optimized Arr::set to handle single-key cases early, reducing unnecessary loop execution and improving readability.
  • Optimized Arr::join by storing the count of the array once instead of calling count() multiple times, improving performance slightly and making the logic cleaner.

@JordanchoEftimov JordanchoEftimov deleted the optimise-arr-set-and-join branch June 14, 2025 23:05
@JordanchoEftimov
Copy link
Contributor Author

Closed and reopened a new one here #56043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant