-
Notifications
You must be signed in to change notification settings - Fork 115
Fix Kanvas Logo Background Color #588 #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mr. @M-DEV-1, I wonder if you wouldn't mind giving @HIMU-2001 some feedback here. |
Hi @HIMU-2001, @Ayushmore1214 has a PR up with a similar change, in #602 I have the same question to ask you, is global css style change the only fix? why doesn't it affect the Layer5 icon, or any other icon on the site. Also, a small thing to look into on the main docs.layer5.io/cloud page would be that the Kanvas icon isn't visible on mobile view. |
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
Hi @M-DEV-1 , The CSS rule affected the Kanvas logo because it uses an "img" tag, which matches the img selector. The Cloud logo uses an inline "svg", which is not targeted by that CSS rule—so it remained unaffected. I have fixed the movie view issue, ensuring cloud & kanvas components are in line. |
@HIMU-2001 @Ayushmore1214 Add it as an agenda item to the meeting minutes, if you would :) |
Hi @M-DEV-1 , Could you please help me with if any enhancements are needed in this. |
Hi @HIMU-2001, I'm not sure if you were present on this week's sites meeting but we discussed this PR briefly. To summarise, I'm not entirely sure if changing global styles is the right way because it might be just that one Kanvas logo. |
Sorry, I was not able to join the call. |
Notes for Reviewers
This PR fixes #588
Signed commits