Skip to content

Fix Kanvas Logo Background Color #588 #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HIMU-2001
Copy link
Contributor

Notes for Reviewers

This PR fixes #588

Signed commits

  • Yes, I signed my commits.

Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit febd83f
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/684cbe258ff50100085ec5e7
😎 Deploy Preview https://deploy-preview-604--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@leecalcote
Copy link
Member

Mr. @M-DEV-1, I wonder if you wouldn't mind giving @HIMU-2001 some feedback here.

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 13, 2025

Hi @HIMU-2001,

@Ayushmore1214 has a PR up with a similar change, in #602

I have the same question to ask you, is global css style change the only fix? why doesn't it affect the Layer5 icon, or any other icon on the site.

Also, a small thing to look into on the main docs.layer5.io/cloud page would be that the Kanvas icon isn't visible on mobile view.

Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
@HIMU-2001
Copy link
Contributor Author

HIMU-2001 commented Jun 14, 2025

Hi @M-DEV-1 ,

The CSS rule affected the Kanvas logo because it uses an "img" tag, which matches the img selector. The Cloud logo uses an inline "svg", which is not targeted by that CSS rule—so it remained unaffected.

I have fixed the movie view issue, ensuring cloud & kanvas components are in line.

@vishalvivekm
Copy link
Contributor

@HIMU-2001 @Ayushmore1214
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@HIMU-2001
Copy link
Contributor Author

Hi @M-DEV-1 ,

Could you please help me with if any enhancements are needed in this.

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 17, 2025

Hi @M-DEV-1 ,

Could you please help me with if any enhancements are needed in this.

Hi @HIMU-2001, I'm not sure if you were present on this week's sites meeting but we discussed this PR briefly.

To summarise, I'm not entirely sure if changing global styles is the right way because it might be just that one Kanvas logo.

@HIMU-2001
Copy link
Contributor Author

Sorry, I was not able to join the call.
I would try to implement this without modifying global css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Kanvas Logo Background Color
4 participants