Skip to content

In store pickup silently discards exceptions #3420

Open
@SamJUK

Description

@SamJUK

Currently, exceptions thrown during the in store pickup source distance calculations are being silently discarded. This PR simply logs the exceptions when they are caught.

Preconditions (*)

  1. Google API as Distance Provider
  2. Google API Key with invalid permissions (eg, referrer restrictions applied).

Steps to reproduce (*)

  1. Configure source selection as preconditions
  2. Navigate to checkout, and attempt a pick up at store address lookup

Expected result (*)

  1. Error message in logs outlining, when the lookup failed

Actual result (*)

  1. Error logs are empty, requiring a debugger/source changes to identify the failure reason

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions