-
Notifications
You must be signed in to change notification settings - Fork 483
Adding fleet workbook #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fleet workbook #3022
Conversation
"type": 3, | ||
"content": { | ||
"version": "KqlItem/1.0", | ||
"query": "where type =~ 'Microsoft.DocumentDB/databaseAccounts'\r\n| where name in~ (split(\"{Resources:label}\", \", \"))\r\n| summarize dcount(name)\r\n\r\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query is doing a count of database accounts, but your parameters are for fleetspace accounts. Is this on purpose? I can see users being confused if parameters did one query but this query does another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this needs to happen b/c of the arg implementation. We don't have fleetspaceaccount queryable in arg justg yet since this is a preview feature.
"resourceType": "microsoft.documentdb/fleets", | ||
"metricScope": 0, | ||
"resourceIds": [ | ||
"/subscriptions/220fc532-6091-423c-8ba0-66c2397d591b/resourceGroups/fleets-bug-bash/providers/Microsoft.DocumentDB/fleets/stef-fleet-bug-bash2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource param not hooked up
"{Resources}" | ||
], | ||
"timeContextFromParameter": "TimeRange", | ||
"timeContext": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove staic time context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding a help link for how to onboard to consumed RU/s
Summary
Explain your changes, so people looking at the PR know what and why, the code changes are the how.
Screenshots
If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.
Validation
Validate your changes using one or more of the testing methods.
Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!
Checklist
When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.