`jsconfig.*.json` don't have `"allowJs": true` by default

[adamscott]

🔎 Search Terms

jsconfig resolution reference

🕗 Version & Regression Information

• The issue was there for TypeScript (tsconfig.json) in 3.9.10
• The issue was fixed on the TypeScript (tsconfig.json) (at least) in 4.0.8
• The issue was always there for JavaScript (jsconfig.json)

⏯ Playground Link

No response

💻 Code

Minimal reproduction project

local-reference-files.zip

File tree

This is the file tree of the MRP.

.
├── javascript
│   ├── browser.js
│   ├── jsconfig.browser.json
│   ├── jsconfig.json
│   ├── jsconfig.node.json
│   └── node.js
└── typescript
    ├── browser.ts
    ├── node.ts
    ├── tsconfig.browser.json
    ├── tsconfig.json
    └── tsconfig.node.json

Files

// javascript/jsconfig.json
{
  "references": [{ "path": "./jsconfig.node.json" }, { "path": "./jsconfig.browser.json" }]
}

// javascript/jsconfig.browser.json
{
  "compilerOptions": {
    "composite": true
  },
  "include": ["browser.js"]
}

// javascript/jsconfig.node.json
{
  "compilerOptions": {
    "composite": true
  },
  "include": ["node.js"]
}

// typescript/tsconfig.json
{
  "references": [{ "path": "./tsconfig.node.json" }, { "path": "./tsconfig.browser.json" }]
}

// typescript/tsconfig.browser.json
{
  "compilerOptions": {
    "composite": true
  },
  "include": ["browser.ts"]
}

// typescript/tsconfig.node.json
{
  "compilerOptions": {
    "composite": true
  },
  "include": ["node.ts"]
}

🙁 Actual behavior

In the typescript directory:

• browser.ts resolves to use tsconfig.browser.json
• node.ts resolves to use tsconfig.node.json

In the javascript directory:

• browser.js resolves to use jsconfig.json
• node.js resolves to use jsconfig.json
  (because jsconfig.*.json don't have "allowJs": true by default.)

🙂 Expected behavior

In the typescript directory:

• browser.ts resolves to use tsconfig.browser.json
• node.ts resolves to use tsconfig.node.json

In the javascript directory:

• browser.js resolves to use jsconfig.browser.json
• node.js resolves to use jsconfig.node.json

Additional information about the issue

• It doesn't seem to matter that the file is called jsconfig.json or tsconfig.json, it seems that it's the resolution of JavaScript config files that is broken.

[sheetalkamat]

There is typo in your example "compileOptions": instead of "compilerOptions": {

[adamscott]

There is typo in your example "compileOptions": instead of "compilerOptions": {

Updated the MRP with the typo fixed. It doesn't really affect the bug, though.

[sheetalkamat]

the jsconfig.*.json need to have allowJs to be able to pickup the file since by default only jsconfig.json has that on.

[adamscott]

the jsconfig.*.json need to have allowJs to be able to pickup the file since by default only jsconfig.json has that on.

That fixes the issue indeed. But shouldn't every jsconfig.*.json have "allowJs": true by default?

[RyanCavanaugh]

The current rule is that if the file is named jsconfig.json, it gets allowJs, otherwise it doesn't

There are a bunch of other rules one could imagine but I don't really see how any of them would be definitively more intuitive. jsconfig.*.json would exclude jsconfig-debug.json, jsconfig*.json would exclude jsbuild.json, js*.json would start including js-min.json when maybe that's not expected, and so on. We can't remove the grey area by moving where the arbitrary cutoff occurs and the current rule is at least maximally close to one side vs the other.

[typescript-bot]

This issue has been marked as "Not a Defect" and has seen no recent activity. It has been automatically closed for house-keeping purposes.