Skip to content

CI/CD - Update OS of runner to the latest. #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 30, 2025
Merged

CI/CD - Update OS of runner to the latest. #702

merged 17 commits into from
Apr 30, 2025

Conversation

polarG
Copy link
Contributor

@polarG polarG commented Apr 17, 2025 •
edited
Loading

  • Upgrade OS of github runner used by lint to the latest.
  • Add symbolic link for clang-format to version 14.
  • Update importlib_metadata version since it is too old (inside nvcr.io/nvidia/pytorch:20.12-py3) and failed the 11.1 build.

@polarG polarG added the CI/CD Continuous integration or deployment label Apr 17, 2025
@polarG polarG requested a review from a team as a code owner April 17, 2025 20:26
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (b13ef28) to head (1a0db53).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          99       99           
  Lines        7211     7211           
=======================================
  Hits         6178     6178           
  Misses       1033     1033
Flag Coverage Δ
cpu-python3.10-unit-test 71.37% <ø> (ø)
cpu-python3.12-unit-test 71.37% <ø> (ø)
cpu-python3.7-unit-test 71.34% <ø> (ø)
cuda-unit-test 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG changed the title Update OS of runner to the latest. CI/CD - Update OS of runner to the latest. Apr 21, 2025
abuccts
abuccts reviewed Apr 21, 2025
View reviewed changes
abuccts
abuccts reviewed Apr 22, 2025
View reviewed changes
abuccts
abuccts approved these changes Apr 23, 2025
View reviewed changes
dpower4
dpower4 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@dpower4 dpower4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

abuccts
abuccts requested changes Apr 29, 2025
View reviewed changes
hongtaozhang added 4 commits April 29, 2025 17:08
Revert "Keep only 1 image pull for storage shortage."
6ca8508 
This reverts commit 975e65f.
Revert "Revert to comma seperated tags."
f50f2c4 
This reverts commit 88ec4e4.

	modified:   .github/workflows/build-image.yml
Revert "Docker can only pull one image per command. To pull multiple …
2f1a26f 
…images, loop through them individually."

This reverts commit a6eaba7.

	modified:   .github/workflows/build-image.yml
Revert "Correct tags format."
28f96bc 
This reverts commit 2810d84.

	modified:   .github/workflows/build-image.yml
abuccts
abuccts reviewed Apr 30, 2025
View reviewed changes
@polarG @abuccts
Update .github/workflows/lint.yml
1a0db53 
combine cmds.

Co-authored-by: Yifan Xiong <yifan.xiong@microsoft.com>
@polarG polarG requested a review from abuccts April 30, 2025 06:42
@polarG polarG enabled auto-merge (squash) April 30, 2025 06:43
@polarG polarG merged commit 330c68a into main Apr 30, 2025
22 checks passed
@polarG polarG deleted the hongtaozhang/update-os-github-runner branch April 30, 2025 23:43
@guoshzhao guoshzhao mentioned this pull request May 14, 2025
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuccts abuccts

@dpower4 dpower4

Assignees
No one assigned
Labels
CI/CD Continuous integration or deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polarG @abuccts @dpower4