event handling for custom chat modes #250012
Conversation
| } | ||
| })); | ||
| this._register(this.fileService.onDidFilesChange(e => { | ||
| if (e.affects(this.userDataService.currentProfile.promptsHome)) { |
There was a problem hiding this comment.
@aeschli this is problematic I think: the onDidFilesChange event is only firing for folders or files where you called fileService.watch. I think we are doing that here:
But I would consider doing an explicit watch here to ensure the watcher is setup (multiple same watchers are folded into 1).
| eventEmitter.fire(); | ||
| return; | ||
| } | ||
| if (parentFolders.some(folder => e.affects(folder))) { |
There was a problem hiding this comment.
@aeschli I wonder how this can happen since the watching does not seem to be recursive.
| @@ -55,6 +57,29 @@ export class PromptFilesLocator { | |||
| return files.filter(file => getPromptFileType(file) === type); | |||
| } | |||
|
|
|||
| public getFilesUpdatedEvent(type: PromptsType): Event<void> { | |||
There was a problem hiding this comment.
@aeschli I find this a bit of a weird pattern to return an event from a method: esp. since you register disposables to the PromptFilesLocator, the lifecycle seems bound by "the big guy" and not the one calling it. This means you pile up listeners for as often as the method is called, only disposing them when "the big guy" goes away (likely never).
I would rather do 1 event that is fixed for the PromptsType to follow what we do in other places.
No description provided.