Skip to content

New package: zelenkov.WixTrim version 1.0.2466.20969 #256040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

New package: zelenkov.WixTrim version 1.0.2466.20969 #256040

merged 2 commits into from
May 21, 2025
+51 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented May 13, 2025 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Image

Warning

This package requires .NET Framework 3.5 as a Windows Feature, which can't be installed in Windows Sandbox instance. 😞

Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

@Dragon1573
New package: zelenkov.WixTrim version 1.0.2466.20969

Verified

This commit was signed with the committer’s verified signature.
Dragon1573 ❤是纱雾酱哟～
GPG key ID: B9CDB793EDD55E32
Verified
Learn about vigilant mode
Loading
Loading status checks…
aa48cac 
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-256040-20250513-1

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Validation-Unapproved-URL labels May 13, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\WixTrim.exe returned exit code: -2146232576

Hex Dec Inverted Dec Symbol Description
80131700 -2146232576 2148734720 Dependency on WindowsFeatues,specifically netfx3.

(Automated response - build 1052.)

@Dragon1573
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
10b8dfc 
- Add required **.NET Framework 3.5** as a Windows Feature dependency
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-256040-20250513-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Validation-Unapproved-URL New-Package labels May 13, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Validation-Unapproved-URL labels May 13, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\WixTrim.exe returned exit code: -532459699

Hex Dec Inverted Dec Symbol Description
E0434F4D -532459699 3762507597 Unhandled exception in .NET application.

(Automated response - build 1053.)

@stephengillie
Copy link
Collaborator

Regarding Validation-Unapproved-URL , #254656 (comment)

@stephengillie
Copy link
Collaborator

Verify:
I thought it might be a CLI so ran it with --version:
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 21, 2025
@stephengillie stephengillie merged commit db40c7d into microsoft:master May 21, 2025
1 check passed
@Dragon1573 Dragon1573 deleted the issues/254656 branch May 21, 2025 03:27
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot]

@stephengillie stephengillie

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: WixTrim.WixTrim
3 participants
@Dragon1573 @wingetbot @stephengillie