-
Notifications
You must be signed in to change notification settings - Fork 13
feat(web): add web generator #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 72.12% 70.54% -1.58%
==========================================
Files 117 128 +11
Lines 9984 10926 +942
Branches 597 633 +36
==========================================
+ Hits 7201 7708 +507
- Misses 2780 3211 +431
- Partials 3 7 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎉 The code now dehydrates to the client so it can render without JavaScript! |
Wow 😵💫 and what about codetab |
It rehydrates and runs with JS, but if you don't have JS, you can still view the docs. I used React's SSRing |
@AugustinMauroy and I got search to finally work 🎉 |
024bbea
to
dbfe55d
Compare
@nodejs/nodejs-website @nodejs/web-infra |
@nodejs/collaborators @nodejs/web-infra @nodejs/nodejs-website If you could be so kind as to review https://api-docs-tooling.vercel.app/ and come up with a list of things that still need to be completed, it would be helpful. I know it's a bit tedious, but it'll help with the development significantly. Note that we are aware of the following issues:
Note that we are in the process of making the following improvements:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@ovflowd Did something change on the main branch that required a fast-forward? I've undone that commit to see if it fixes the deployment. |
Please don't undo the commit lol |
It was just updated vercel permissions that needed to be fixed. |
Ahh I see, apologies. |
I've re-requested review from previous web-team reviewers, since this PR has undergone substantial changes since the last code review comment. I'm pleased to feel that this PR is in a place where it can land with minimal adjustments (where a follow-up tracking improvements can be made, see the list of improvements in the PR description). |
Fixes #7.
This PR adds the web generator.
Tasks / Issues
P1 – Must Complete Before Merge
P2 – Must complete before migration
extends
keywordentry.changes
aren't converted to HTML #326P3 – Can Be Done in a Follow-up
mustache
dependencyDataTag
Get a preview
Footnotes
Add things as they appear, or leave review comments. ↩ ↩2 ↩3