BUG: fillna with DataFrame input should preserve dtype when possible #61742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we now operate column-wise and use This also preserves extension dtypes like Let me know if this behavior change is fine, happy to update the test or tweak the logic based on what’s preferred! |
simonjayhawkins
added
Bug
Dtype Conversions
| # restore original dtype if fallback to object occurred | ||
| if lhs.dtype == rhs.dtype and filled.dtype == object: | ||
| try: | ||
| filled = filled.astype(lhs.dtype) |
There was a problem hiding this comment.
id expect this to be handled by Series.where. is it not?
| @@ -7145,7 +7145,24 @@ def fillna( | |||
| else: | |||
| new_data = self._mgr.fillna(value=value, limit=limit, inplace=inplace) | |||
| elif isinstance(value, ABCDataFrame) and self.ndim == 2: | |||
| new_data = self.where(self.notna(), value)._mgr | |||
| filled_columns = {} | |||
| for col in self.columns: | |||
There was a problem hiding this comment.
doing this column-by-column is going to mean a performance hit for non-object cases. i suspect we need to do this at the Block level in order to avoid that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filling a DataFrame with another DataFrame using
fillna, columns with matching dtypes were being unnecessarily cast toobjectdue to use ofnp.where.This PR updates the logic to use pandas’
Series.where, which is dtype-safe and respects extension and datetime types.