Upgrade to use TensorNetworkQuantumSimulator #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lw-anderson
requested changes
Jun 10, 2025
| @@ -13,6 +13,8 @@ | |||
| from qiskit import transpile | |||
There was a problem hiding this comment.
should we just delete this whole file?
| expect_sigmaz = real.(expect(ψ, observables; (cache!)=Ref(bpc))) | ||
| end | ||
|
|
||
| function pauli_expectation_advanced(pauli, ψ, sites, boundarymps_rank) |
There was a problem hiding this comment.
what is the purpose of this function? how does it differ from the above? when is it used? perhaps the answer to this should be in a docstring?
Okay, this is fixed. Just a couple of minor suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The main functionality change here is the adoption of automatic BP caching and performance improvements. Currently there is no user-friendly way to set the BP cache parameters but this should be easy enough to do in a next round of changes