tests/ui: A New Order [17/N]
#143195
Merged
tests/ui: A New Order [17/N]
#143195
+111
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
tgross35
reviewed
Jun 30, 2025
Comment on lines
1
to
4
| //! Test that basic multiline comments are parsed correctly. | ||
| //! | ||
| //! This checks that the lexer properly handles `/* */` style comments | ||
| //! without causing parsing errors. |
There was a problem hiding this comment.
The second paragraph is kind of redundant with the first - /* */ are multiline comments, and "without causing parsing errors" isn't really any different "parsed correctly". So I think the second can be removed.
Comment on lines
1
to
4
| //! Test that multibyte Unicode characters don't crash the compiler. | ||
| //! | ||
| //! This checks that the parser correctly handles non-ASCII characters | ||
| //! in string literals without causing an ICE. |
There was a problem hiding this comment.
Same here, second comment kind of just restates the first
|
Two nits then please squash. Also, fwiw: if you're planning to request a review from me, no need to split the commits up in the first place other than the move. Maybe doing that made a bit more sense compared to having everything (including move) in a single commit? Since if the move isn't split off, the overall diff is a bit tough to follow (looks like files getting added and removed), but if the move is done in a separate commit then the diff for any following commits looks "normal". |
|
@rustbot ready |
tgross35
approved these changes
Jun 30, 2025
|
Thank you! |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 30, 2025
Rollup of 14 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations) - #143066 (Use let chains in the new solver) - #143090 (Workaround for memory unsafety in third party DLLs) - #143118 (`tests/ui`: A New Order [15/N]) - #143159 (Do not freshen `ReError`) - #143168 (`tests/ui`: A New Order [16/N]) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143190 (Use the `new` method for `BasicBlockData` and `Statement`) - #143195 (`tests/ui`: A New Order [17/N]) - #143196 (Port #[link_section] to the new attribute parsing infrastructure) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - #143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 30, 2025
Rollup merge of #143195 - Kivooeo:tf17, r=tgross35 `tests/ui`: A New Order [17/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? `@tgross35`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Intermediate commits are intended to help review, but will be squashed prior to merge.
Some
tests/ui/housekeeping, to trim down number of tests directly undertests/ui/. Part of #133895.r? @tgross35