fix: include TypeScript source files in react-refresh-utils compilation #80531
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves missing source map warnings in VS Code by copying TypeScript source files to the compiled @next/react-refresh-utils package. This allows VS Code debugger to properly locate source files referenced by source maps. Fixes vercel#24349
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug
fixes #numberWhat?
This PR fixes VS Code debugging warnings by including TypeScript source files in the compiled
@next/react-refresh-utilspackage.Why?
When debugging Next.js applications in VS Code, developers encounter warnings about missing source maps because the source maps reference TypeScript files that don't exist in the compiled package. The source maps point to paths like
../../internal/ReactRefreshModule.runtime.tsbut these TypeScript files are not included in the published package, causing VS Code to show "Could not read source map" warnings.How?
Modified the
ncc_react_refresh_utilsfunction inpackages/next/taskfile.jsto:ReactRefreshWebpackPlugin.tsloader.tsruntime.tsinternal/ReactRefreshModule.runtime.tsinternal/helpers.tsThe fix is minimal and safe - it only adds the missing TypeScript source files without modifying any existing compilation logic.
Fixes #24349