[slice]support different shape case for GPUScatterAdd op #73971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… index3 slice-check
zhanghonggeng
changed the title
|
/re-run all-failed |
1 similar comment
|
/re-run all-failed |
xiaoguoguo626807
approved these changes
Jul 14, 2025
xiaoguoguo626807
merged commit 77166d2
into
PaddlePaddle:develop
83 of 86 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Performance Optimization
PR Types
Improvements
Description
问题背景：输入:(108, 64, 12288), axis:0, index:input_shape[axis]为例，gather反向相比torch慢60%，因此考虑优化gather_gard。
实现GPUScatterAdd kernel替换GPUScatterAssign。GPUScatterAdd kernel支持stride，通过stride计算将kernel内索引计算转换为首地址+偏移量，简化了kernel内复杂的索引计算，上述case中有60%性能提升。
对应slice case中输入：Tensor([108,64,12288],"float32"), index：Tensor([2,4,6],"int64") 。
2.73 -> 1.21,
pcard-67164