Handle spaces in parens in srcset descriptors. Fixes #180 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| <dd> | ||
| Advance <var>position</var> to the next character in <var>input</var>. | ||
| If <var>current token</var> is not empty, |
There was a problem hiding this comment.
EOF is handled lower down. It's the same except you don't advance to the next character since that makes little sense for EOF.
There was a problem hiding this comment.
Wouldn't the above add the EOF to descriptors if the input ends with a comma?
There was a problem hiding this comment.
Forget about it, read it all wrong
|
Looks good! |
yoavweiss
added a commit
that referenced
this pull request
May 23, 2014
Handle spaces in parens in srcset descriptors. Fixes #180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.