Skip to content

Fix intro and examples. Fixes #202 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2014

Conversation

zcorpan
Copy link

@zcorpan zcorpan commented Jun 9, 2014

No description provided.

&lt;img alt="<a href="images/a-rad-wolf.gif">A rad wolf</a>"
src="pic1x.jpg" width="500" height="500">
&lt;/picture>
&lt;img src="pic1x.jpg" srcset="pic2x.jpg 2x, pic4x.jpg 4x"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you drop the 1x here? It's definitely a bad idea to only ship 2x.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src is the 1x.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Carry on, then.

tabatkins added a commit that referenced this pull request Jun 9, 2014
Fix intro and examples. Fixes #202
@tabatkins tabatkins merged commit 748c03b into ResponsiveImagesCG:gh-pages Jun 9, 2014
@zcorpan zcorpan deleted the fix-202 branch June 10, 2014 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants