Adding use case for managing source swapping #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| breakpoint, there is a delay while the image is loaded. Any CSS which | ||
| matches the breakpoint applies itself. However, we're stuck with the | ||
| previous image while the new one loads. If we had a JavaScript event | ||
| fire when the new image is loaded, loadstart for example. The user |
There was a problem hiding this comment.
You want to avoid talking about a solution here, just the problem you're trying to solve.
| When a new image is loaded via <source> after hitting a new | ||
| breakpoint, there is a delay while the image is loaded. Any CSS which | ||
| matches the breakpoint applies itself. However, we're stuck with the | ||
| previous image while the new one loads. This can result in blurry |
There was a problem hiding this comment.
Can you s/we're stuck with the previous image/the previous image still displays/?
|
Cool. Now, if you can just address #58 (comment) we're good to go :) |
|
LGTM |
yoavweiss
added a commit
that referenced
this pull request
Jul 29, 2015
Adding use case for managing source swapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding use case as requested. For reference: http://discourse.wicg.io/t/need-loadstart-event-on-picture-src-change/985