Skip to content

[pylint] stabilizing PLR0917 #19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodeMan62
Copy link
Contributor

Summary

closes #16867

Test Plan

testing mentioned in contributing.md .

Copy link
Contributor

github-actions bot commented Jul 9, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+2501 -0 violations, +0 -0 fixes in 12 projects; 43 projects unchanged)

aiven/aiven-client (+21 -0 violations, +0 -0 fixes)

+ aiven/client/argx.py:316:9: PLR0917 Too many positional arguments (9/5)
+ aiven/client/client.py:1275:9: PLR0917 Too many positional arguments (9/5)
+ aiven/client/client.py:1315:9: PLR0917 Too many positional arguments (6/5)
+ aiven/client/client.py:1340:9: PLR0917 Too many positional arguments (6/5)
+ aiven/client/client.py:1425:9: PLR0917 Too many positional arguments (11/5)
+ aiven/client/client.py:1461:9: PLR0917 Too many positional arguments (12/5)
+ aiven/client/client.py:1739:9: PLR0917 Too many positional arguments (7/5)
+ aiven/client/client.py:212:9: PLR0917 Too many positional arguments (6/5)
+ aiven/client/client.py:2249:9: PLR0917 Too many positional arguments (6/5)
+ aiven/client/client.py:2956:9: PLR0917 Too many positional arguments (9/5)
... 11 additional changes omitted for project

PlasmaPy/PlasmaPy (+63 -0 violations, +0 -0 fixes)

+ src/plasmapy/analysis/nullpoint.py:143:5: PLR0917 Too many positional arguments (11/5)
+ src/plasmapy/analysis/nullpoint.py:1461:5: PLR0917 Too many positional arguments (8/5)
+ src/plasmapy/analysis/nullpoint.py:1546:5: PLR0917 Too many positional arguments (7/5)
+ src/plasmapy/analysis/nullpoint.py:570:5: PLR0917 Too many positional arguments (8/5)
+ src/plasmapy/analysis/time_series/conditional_averaging.py:305:9: PLR0917 Too many positional arguments (7/5)
+ src/plasmapy/diagnostics/charged_particle_radiography/detector_stacks.py:59:9: PLR0917 Too many positional arguments (6/5)
+ src/plasmapy/diagnostics/charged_particle_radiography/synthetic_radiography.py:207:9: PLR0917 Too many positional arguments (12/5)
+ src/plasmapy/diagnostics/charged_particle_radiography/synthetic_radiography.py:359:9: PLR0917 Too many positional arguments (6/5)
+ src/plasmapy/diagnostics/charged_particle_radiography/synthetic_radiography.py:485:9: PLR0917 Too many positional arguments (8/5)
+ src/plasmapy/diagnostics/charged_particle_radiography/synthetic_radiography.py:613:9: PLR0917 Too many positional arguments (7/5)
... 53 additional changes omitted for project

apache/airflow (+1361 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ airflow-core/src/airflow/api/client/local_client.py:38:9: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/common/parameters.py:346:5: PLR0917 Too many positional arguments (7/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:126:5: PLR0917 Too many positional arguments (8/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:262:5: PLR0917 Too many positional arguments (10/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:152:5: PLR0917 Too many positional arguments (7/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:307:5: PLR0917 Too many positional arguments (15/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_tags.py:44:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_versions.py:87:5: PLR0917 Too many positional arguments (9/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_warning.py:51:5: PLR0917 Too many positional arguments (7/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py:270:5: PLR0917 Too many positional arguments (11/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py:78:5: PLR0917 Too many positional arguments (16/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/event_logs.py:68:5: PLR0917 Too many positional arguments (15/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:48:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/job.py:55:5: PLR0917 Too many positional arguments (11/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py:166:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py:74:5: PLR0917 Too many positional arguments (11/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:125:5: PLR0917 Too many positional arguments (19/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:237:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:384:5: PLR0917 Too many positional arguments (21/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:588:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:624:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:751:5: PLR0917 Too many positional arguments (8/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:798:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:834:5: PLR0917 Too many positional arguments (9/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:122:5: PLR0917 Too many positional arguments (9/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:182:5: PLR0917 Too many positional arguments (6/5)
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:276:5: PLR0917 Too many positional arguments (6/5)
... 1334 additional changes omitted for project

apache/superset (+95 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ scripts/check-env.py:30:9: PLR0917 Too many positional arguments (6/5)
+ scripts/cypress_run.py:39:5: PLR0917 Too many positional arguments (6/5)
+ superset/async_events/cache_backend.py:109:9: PLR0917 Too many positional arguments (12/5)
+ superset/async_events/cache_backend.py:27:9: PLR0917 Too many positional arguments (11/5)
+ superset/charts/client_processing.py:64:5: PLR0917 Too many positional arguments (10/5)
+ superset/commands/importers/v1/utils.py:105:5: PLR0917 Too many positional arguments (7/5)
+ superset/commands/sql_lab/execute.py:69:9: PLR0917 Too many positional arguments (9/5)
+ superset/common/query_object_factory.py:52:9: PLR0917 Too many positional arguments (7/5)
+ superset/common/utils/query_cache_manager.py:52:9: PLR0917 Too many positional arguments (14/5)
+ superset/common/utils/query_cache_manager.py:86:9: PLR0917 Too many positional arguments (7/5)
... 85 additional changes omitted for project

aws/aws-sam-cli (+313 -0 violations, +0 -0 fixes)

+ samcli/cli/cli_config_file.py:176:5: PLR0917 Too many positional arguments (7/5)
+ samcli/commands/_utils/options.py:210:5: PLR0917 Too many positional arguments (6/5)
+ samcli/commands/_utils/table_print.py:104:5: PLR0917 Too many positional arguments (7/5)
+ samcli/commands/_utils/table_print.py:16:5: PLR0917 Too many positional arguments (6/5)
+ samcli/commands/build/build_context.py:54:9: PLR0917 Too many positional arguments (27/5)
+ samcli/commands/build/command.py:136:5: PLR0917 Too many positional arguments (26/5)
+ samcli/commands/build/command.py:199:5: PLR0917 Too many positional arguments (23/5)
+ samcli/commands/delete/command.py:66:5: PLR0917 Too many positional arguments (8/5)
+ samcli/commands/delete/command.py:91:5: PLR0917 Too many positional arguments (6/5)
+ samcli/commands/delete/delete_context.py:32:9: PLR0917 Too many positional arguments (6/5)
... 303 additional changes omitted for project

bokeh/bokeh (+42 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ examples/basic/annotations/colorbar_log.py:15:5: PLR0917 Too many positional arguments (6/5)
+ examples/models/gauges.py:48:5: PLR0917 Too many positional arguments (7/5)
+ examples/plotting/histogram.py:17:5: PLR0917 Too many positional arguments (6/5)
+ examples/topics/hierarchical/treemap.py:26:5: PLR0917 Too many positional arguments (6/5)
+ src/bokeh/client/session.py:198:5: PLR0917 Too many positional arguments (6/5)
+ src/bokeh/document/callbacks.py:223:9: PLR0917 Too many positional arguments (7/5)
+ src/bokeh/document/events.py:290:9: PLR0917 Too many positional arguments (6/5)
+ src/bokeh/document/events.py:387:9: PLR0917 Too many positional arguments (7/5)
+ src/bokeh/document/events.py:479:9: PLR0917 Too many positional arguments (7/5)
+ src/bokeh/document/events.py:577:9: PLR0917 Too many positional arguments (6/5)
... 32 additional changes omitted for project

freedomofpress/securedrop (+11 -0 violations, +0 -0 fixes)

+ securedrop/journalist_app/sessions.py:101:9: PLR0917 Too many positional arguments (6/5)
+ securedrop/models.py:412:9: PLR0917 Too many positional arguments (6/5)
+ securedrop/pretty_bad_protocol/_meta.py:134:9: PLR0917 Too many positional arguments (9/5)
+ securedrop/pretty_bad_protocol/_meta.py:787:9: PLR0917 Too many positional arguments (7/5)
+ securedrop/pretty_bad_protocol/_meta.py:859:9: PLR0917 Too many positional arguments (14/5)
+ securedrop/pretty_bad_protocol/gnupg.py:56:9: PLR0917 Too many positional arguments (8/5)
+ securedrop/tests/factories.py:54:9: PLR0917 Too many positional arguments (10/5)
+ securedrop/tests/test_journalist.py:3517:5: PLR0917 Too many positional arguments (6/5)
+ securedrop/tests/test_journalist.py:3555:5: PLR0917 Too many positional arguments (6/5)
+ securedrop/tests/test_journalist_api.py:771:5: PLR0917 Too many positional arguments (6/5)
... 1 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0917 2501 2501 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added breaking Breaking API change do-not-merge Do not merge this pull request labels Jul 9, 2025
@ntBre
Copy link
Contributor

ntBre commented Jul 9, 2025

This is a very opinionated rule, and we may not want to stabilize it before #1774. That's also quite a large number of ecosystem hits, and there's no autofix really possible in this situation.

@ntBre ntBre added this to the v0.13 milestone Jul 9, 2025
@CodeMan62
Copy link
Contributor Author

so do i have to close this or wait to get things done first?

@ntBre
Copy link
Contributor

ntBre commented Jul 9, 2025

You don't have to close it, but there's a good chance that we won't merge this. All of these breaking changes can only come out in "minor" releases (when we bump the version from 0.12 to 0.13, unlike our weekly patch releases). So we'll need to reassess all of these when we prepare for the next minor release in a couple of months.

@dhruvmanila dhruvmanila marked this pull request as draft July 10, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change do-not-merge Do not merge this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize PLR0917
2 participants