Skip to content

fix(ext/node): invalid zero windowBits for compression #29666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(ext/node): invalid zero windowBits for compression #29666

wants to merge 6 commits into from
+43 −29

Conversation

littledivy
Copy link
Member

Enables parallel/test-zlib-zero-windowsBits.js

Ref #29638

@littledivy
fix(ext/node): invalid zero windowBits for compression
eba0d48 
Enables `parallel/test-zlib-zero-windowsBits.js`

Ref denoland#29638
@littledivy littledivy mentioned this pull request Jun 9, 2025
Open
40 tasks
kt3k
kt3k previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI gets green

@kt3k kt3k dismissed their stale review June 18, 2025 00:53

Looks like this fix break the below cases?

  • parallel/test-zlib-close-after-error.js
  • parallel/test-zlib-convenience-methods.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @kt3k