Skip to content

feat: --allow-net supports CIDR ranges #29704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

wuurrd
Copy link
Contributor

@wuurrd wuurrd commented Jun 11, 2025

Remove traffic to all local network with this PR using --deny-net=...

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025

CLA assistant check
All committers have signed the CLA.

@wuurrd wuurrd force-pushed the flags-net-allow-subnet-ranges branch 4 times, most recently from a7c90af to 1dcf466 Compare June 11, 2025 16:00
@wuurrd wuurrd force-pushed the flags-net-allow-subnet-ranges branch 4 times, most recently from e045786 to e2f2d0f Compare June 12, 2025 11:39
@wuurrd wuurrd requested a review from anonhostpi June 12, 2025 11:40
Copy link

@anonhostpi anonhostpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do not have write access to the repository though. You will need to request another reviewer.

@wuurrd wuurrd force-pushed the flags-net-allow-subnet-ranges branch from e2f2d0f to 6d5bb80 Compare June 16, 2025 09:48
@bartlomieju bartlomieju added this to the 2.4.0 milestone Jun 16, 2025
@bartlomieju bartlomieju changed the title feat(flags): --net should allow specifying CIDR ranges feat: --allow-net supports CIDR ranges Jun 26, 2025
@bartlomieju
Copy link
Member

I think we should have an intergration test for this too, it should be added around here:

fn net_fetch_localhost_subdomain() {

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, this is a great addition!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 3cefece into denoland:main Jun 26, 2025
18 checks passed
@wuurrd wuurrd deleted the flags-net-allow-subnet-ranges branch July 1, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants