-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat: --allow-net supports CIDR ranges #29704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --allow-net supports CIDR ranges #29704
Conversation
a7c90af
to
1dcf466
Compare
e045786
to
e2f2d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do not have write access to the repository though. You will need to request another reviewer.
e2f2d0f
to
6d5bb80
Compare
I think we should have an intergration test for this too, it should be added around here: deno/tests/integration/run_tests.rs Line 1442 in e8d9d59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, this is a great addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove traffic to all local network with this PR using --deny-net=...