refactor(ext/node): use _events.mjs as node:events, and remove events.ts
#29815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
changed the title
_events.mjs as node:events, and remove events.ts_events.mjs as node:events, and remove events.ts
|
retracting for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant
polyfills/events.tsfile and usespolyfills/_events.mjsdirectly asnode:eventsmodule.This makes stack trace from
node:eventsseem more similar to Node.js (For example, the location ofEventEmitter.prototype.emitis nownode:eventsinstead ofext:deno_node/_events.mjs), and also this makes further compat work ofnode:asserteasier (because some test cases assert about callsites of event emitter methods).towards #29801