Add disabled `waitForPodsReady` to configuration by default.

[PBundyra]

What would you like to be added:
I'd like to add waitForPodsReady to configuration by default, which is now commented out. It shouldn't have any impact though as it's disabled by default.

Why is this needed:
This will increase consistency in the defaults.go file.

Completion requirements:

This enhancement requires the following artifacts:

• Design doc
• API change
• Docs update

The artifacts should be linked in subsequent comments.

[kannon92]

/help
/good-first-issue

You want to add this as default with WaitForPodsReady disabled?

https://github.com/kubernetes-sigs/kueue/blob/main/config/components/manager/controller_manager_config.yaml#L26

Just uncomment WaitForPodsReady and disable it?

[k8s-ci-robot]

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

You want to add this as default with WaitForPodsReady disabled?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[OMNARAYANYU]

/assign

[PBundyra]

/help /good-first-issue

You want to add this as default with WaitForPodsReady disabled?

https://github.com/kubernetes-sigs/kueue/blob/main/config/components/manager/controller_manager_config.yaml#L26

Just uncomment WaitForPodsReady and disable it?

Exactly

[tenzen-y]

IIUC, if waitForPodsReady is null, we do not configure it:

kueue/apis/config/v1beta1/defaults.go

Line 119 in 06d4c76

if cfg.WaitForPodsReady != nil {

So, my question is, what is the motivation to configure those parameters by default?

[OMNARAYANYU]

IIUC, if waitForPodsReady is null, we do not configure it:

kueue/apis/config/v1beta1/defaults.go

Line 119 in 06d4c76

if cfg.WaitForPodsReady != nil {
So, my question is, what is the motivation to configure those parameters by default?

are you recommending this to be an invalid issue?

[tenzen-y]

IIUC, if waitForPodsReady is null, we do not configure it:
kueue/apis/config/v1beta1/defaults.go
Line 119 in 06d4c76
if cfg.WaitForPodsReady != nil {
So, my question is, what is the motivation to configure those parameters by default?

are you recommending this to be an invalid issue?

Sorry for your confusion. I would like to ask this to @PBundyra

[PBundyra]

My primary motivation was to increase consistency across the defaults.go file. Than we could also default the values there, and disable it by default. However with the new changes to the waitForPodsReady field and taking into the account the discussion here I would abandon this idea. Sorry for the late reply

[PBundyra]

Sorry for the confusion