Fix for Streaming bug when working with a client that does not support streaming #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a check for non-empty `Message` in `StreamingResponse.cs` to ensure final messages are sent. - Updated `ErrorResponseException.cs` to include new namespaces and improve HTTP response content reading. - Implemented robust error handling by checking for null or empty `errorBody` and attempting to extract specific error messages.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…xception.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added a conditional check in `StreamingResponse.cs` to append `StreamInfo` only if the channel supports streaming. Improved error handling in `ErrorResponseException.cs` by validating `responseContent` before deserialization, ensuring robustness and proper extraction of error messages.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances response handling and error processing by ensuring final messages are sent and improving error deserialization for better HTTP error content extraction.
- Updated error response deserialization to handle empty error bodies and extract more specific error messages.
- Added a check on the Message field in StreamingResponse to determine when to send the final message.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/Core/Microsoft.Agents.Core/Errors/ErrorResponseException.cs | Improves error body processing with additional deserialization logic for better error details. |
| src/libraries/Builder/Microsoft.Agents.Builder/StreamingResponse.cs | Enhances final message sending condition by checking for non-empty Message content. |
src/libraries/Core/Microsoft.Agents.Core/Errors/ErrorResponseException.cs
Outdated
Show resolved
Hide resolved
…xception.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MattB-msft
changed the title
tracyboehrer
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageinStreamingResponse.csto ensure final messages are sent.ErrorResponseException.csto include new namespaces and improve HTTP response content reading.errorBodyand attempting to extract specific error messages.