Add conditional check for FinalMessage in activity.Text #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic to set `activity.Text` only when `FinalMessage` is null. This prevents overwriting the text if `FinalMessage` is already provided, ensuring the correct message is displayed.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a conditional check when setting activity.Text to ensure that it is only updated when FinalMessage is null, thereby preventing unwanted overwrites.
- Introduces an if block to conditionally update activity.Text.
- Maintains the existing activity properties and behavior when FinalMessage is provided.
tracyboehrer
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logic to set
activity.Textonly whenFinalMessageis null. This prevents overwriting the text ifFinalMessageis already provided, ensuring the correct message is displayed.