Skip to content

Added route rank and sign in handler arguments to Teams Extension #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

tracyboehrer
Copy link
Member

Fixes #322

@Copilot Copilot AI review requested due to automatic review settings June 26, 2025 15:23
@tracyboehrer tracyboehrer requested a review from a team as a code owner June 26, 2025 15:23
@tracyboehrer tracyboehrer enabled auto-merge June 26, 2025 15:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new optional parameters—rank and autoSignInHandlers—to route handler methods in the Teams Extension, enhancing route management functionality.

  • Updated TeamsAgentExtension methods to accept route rank and auto sign-in handlers.
  • Modified AgentExtension's AddRoute method accordingly to propagate the new parameters.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/libraries/Extensions/Microsoft.Agents.Extensions.Teams/App/TeamsAgentExtension.cs Updated multiple route handling methods to include rank and autoSignInHandlers parameters.
src/libraries/Builder/Microsoft.Agents.Builder/AgentExtension.cs Adjusted AddRoute method to accept and forward autoSignInHandlers along with rank.
Comments suppressed due to low confidence (2)

src/libraries/Extensions/Microsoft.Agents.Extensions.Teams/App/TeamsAgentExtension.cs:77

  • Provide descriptive XML comments for the 'rank' and 'autoSignInHandlers' parameters to clarify their purposes and expected values.
        /// <param name="rank"></param>

src/libraries/Builder/Microsoft.Agents.Builder/AgentExtension.cs:18

  • If XML documentation is maintained for public methods, consider adding documentation for the new 'autoSignInHandlers' parameter to explain its role.
        public void AddRoute(AgentApplication agentApplication, RouteSelector routeSelector, RouteHandler routeHandler, bool isInvokeRoute = false, ushort rank = RouteRank.Unspecified, string[] autoSignInHandlers = null) {

@github-actions github-actions bot added the ML: Core Tags changes to core libraries label Jun 26, 2025
@tracyboehrer tracyboehrer merged commit dfeadc8 into main Jul 3, 2025
8 checks passed
@tracyboehrer tracyboehrer deleted the users/tracyboehrer/teams-routerank branch July 3, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ML: Core Tags changes to core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsAgentExtension: Does not allow use of RouteRank or AutoSignInHandlers
2 participants