ExpectReplies during OAuth not handled correctly #342
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
Fixes #346
This PR instead performs a planned refactoring to have CloudAdapter handle both Stream and ExpectReply DeliveryModes via the (renamed to)
ChannelResponseQueue
. This resolves the bug, and simplifies TurnContext. It does complicate CloudAdapter a bit, but some of these changes were planned for A2A/MCP anyway.CloudAdapter
andTurnContext
are the largest changes.Detail
The fundamental issue is that ExpectReplies was handled in TurnContext by buffering responses from the Agent (TurnContext.SendActivity). So, when the TurnContext switched (as would be the case during OAuth Continuation Activity handling), the responses were lost.
There are different ways to handle this. For example, use Adapter.ContinuationActivity and when that is complete, copy the buffered activities on the "inner" TurnContext to the "outer".